mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58508: Introduced method `Resources::allocatableTo` to aggregate reservations.
Date Tue, 13 Jun 2017 15:38:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58508/
-----------------------------------------------------------

(Updated June 13, 2017, 11:38 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-7149
    https://issues.apache.org/jira/browse/MESOS-7149


Repository: mesos


Description
-------

A reservation is allocatable to 'role' iff:
 - it is reserved to ancestor of 'role' in hierarchy, OR
 - it is reserved to 'role' itself, OR
 - it is unreserved.

This is a helper function for reservation delegate, where reserved
resources can be 'delegated' downwards in the hierarchy.


Diffs
-----

  include/mesos/resources.hpp 451b0cef6f84743e3d630104ba6f55665793f2bc 
  include/mesos/v1/resources.hpp c790927353122a4eb2bbbee31c6df57d97f3994b 
  src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 
  src/tests/resources_tests.cpp 71c7544470f44f84ef90f9b31afcd81d46493981 
  src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d 


Diff: https://reviews.apache.org/r/58508/diff/3/


Testing (updated)
-------

comment out https://github.com/apache/mesos/blob/master/src/common/roles.cpp#L71-L74 and `./bin/mesos-tests.sh
--gtest_filter="ResourcesTest.DISABLED_HierarchicalReservations" --gtest_also_run_disabled_tests`


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message