mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.
Date Tue, 13 Jun 2017 08:29:15 GMT


> On June 9, 2017, 6:48 p.m., Benjamin Mahler wrote:
> > src/tests/upgrade_tests.cpp
> > Lines 578-579 (patched)
> > <https://reviews.apache.org/r/59860/diff/1/?file=1743640#file1743640line578>
> >
> >     I wonder if we could have 0 initial delay by default for the tests so that you
don't have to deal with this here. Want to file a ticket? :D

Added https://issues.apache.org/jira/browse/MESOS-7657 and added you as a watcher.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59860/#review177534
-----------------------------------------------------------


On June 13, 2017, 1:22 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59860/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 1:22 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7633
>     https://issues.apache.org/jira/browse/MESOS-7633
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevent allocating non-capable agents' resources to hierarchical roles.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 73d0b42433a1ff3e853e851b8191864b4e233666

>   src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 
> 
> 
> Diff: https://reviews.apache.org/r/59860/diff/2/
> 
> 
> Testing
> -------
> 
> New tests + `make check`.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message