mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 59525: Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.
Date Sun, 11 Jun 2017 05:35:08 GMT


> On June 11, 2017, 5:27 a.m., Greg Mann wrote:
> > src/master/http.cpp
> > Line 2385 (original), 2415 (patched)
> > <https://reviews.apache.org/r/59525/diff/3/?file=1746626#file1746626line2425>
> >
> >     What about tests for these?

To be more specific: at the very least we need tests which verify the filtering behavior of
the `SlaveWriter` & `SlavesWriter`, which are now used commonly across several endpoints.
Hopefully the tests for each of the affected endpoints are verifying that this patch doesn't
change the format of their output at all?

Also, could you update the description to mention '/state' and '/state-summary', since you're
updating those handlers also?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59525/#review177555
-----------------------------------------------------------


On June 9, 2017, 10:04 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59525/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 10:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7416
>     https://issues.apache.org/jira/browse/MESOS-7416
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support of the `VIEW_ROLE` ACL to the results generated by the
> `/slaves` as well as the `GET_AGENTS` API v1 call. This means that
> calls to this endpoint (API call) will hide roles that the user making
> the request is not authorized to see.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
> 
> 
> Diff: https://reviews.apache.org/r/59525/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message