mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 59873: Refactored `HealthChecker` to use `CheckerProcess`.
Date Thu, 08 Jun 2017 16:37:33 GMT


> On June 7, 2017, 4:35 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 255-256 (patched)
> > <https://reviews.apache.org/r/59873/diff/1/?file=1743738#file1743738line266>
> >
> >     Why do not want to leave it as it is now?
> >     ```
> >       create = Duration::create(check.grace_period_seconds());
> >       CHECK_SOME(create);
> >       checkGracePeriod = create.get();
> >     ```

The validation method already checks that the grace period is valid, so there's no need to
check again here.

Also I marked `checkGracePeriod` as `const`, so if I wanted to check that again, I'd have
to move that to an ugly static function...


> On June 7, 2017, 4:35 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 388-391 (patched)
> > <https://reviews.apache.org/r/59873/diff/1/?file=1743738#file1743738line1215>
> >
> >     Let's do this in a separate patch to simplify reviewing.

I'd keep this check in this patch for the aforementioned reason, and move the other extra
validations to a new one.


> On June 7, 2017, 4:35 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 458-472 (patched)
> > <https://reviews.apache.org/r/59873/diff/1/?file=1743738#file1743738line1285>
> >
> >     Does it make sense to do this in a separate patch to simplify reviewing?

Moved to https://reviews.apache.org/r/59902/.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59873/#review177179
-----------------------------------------------------------


On June 7, 2017, 11:56 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59873/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 11:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `HealthChecker` now wraps a `CheckerProcess` and gets check status
> updates via a callback.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
>   src/checks/checker_process.hpp PRE-CREATION 
>   src/checks/checker_process.cpp PRE-CREATION 
>   src/checks/health_checker.hpp 25bf7e99bf5982fd7a6ff5012c231ff89fb7cb39 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59873/diff/2/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message