mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 59101: Enabled authorization when accesing maintenance status in v0 and v1 API.
Date Wed, 07 Jun 2017 13:06:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59101/
-----------------------------------------------------------

(Updated June 7, 2017, 3:06 p.m.)


Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Summary (updated)
-----------------

Enabled authorization when accesing maintenance status in v0 and v1 API.


Bugs: MESOS-7415
    https://issues.apache.org/jira/browse/MESOS-7415


Repository: mesos


Description (updated)
-------

Enables the use of authorization for the `GET_MAINTENANCE_STATUS` v1
API call, as well as to the `maintenance/status` endpoint, using the
ACL `GetMaintenanceStatus` and the action of the same name as the API
call.

It also updates the ApiTests to take into account the authorization
case.


Diffs (updated)
-----

  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
  src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 
  src/tests/master_maintenance_tests.cpp 9edd74a876cd2933d5a5be590a7dd3d10bc54253 


Diff: https://reviews.apache.org/r/59101/diff/5/

Changes: https://reviews.apache.org/r/59101/diff/4-5/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message