mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 59865: Fixed conversion warning in `duration.hpp`.
Date Tue, 06 Jun 2017 22:48:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59865/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-7459
    https://issues.apache.org/jira/browse/MESOS-7459


Repository: mesos


Description
-------

While `ns()` and our other types are `int64_t`, the variable to which
we're assigning is (by definition of `struct timeval`) a `long`. We cast
it because there is no alternative, and we otherwise generate hundreds
of warnings.


Diffs
-----

  3rdparty/stout/include/stout/duration.hpp 138993e25c51efc82d447fe82037bf3a5fe7fd91 


Diff: https://reviews.apache.org/r/59865/diff/1/


Testing
-------

Built `stout-tests` on Windows and Linux, no more `duration.hpp` warnings.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message