mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 59792: Cleaned up leveldb build.
Date Sat, 03 Jun 2017 20:04:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59792/#review176873
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59771, 59772, 59773, 59774, 59776, 59777, 59778, 59779, 59780, 59781, 59782,
59783, 59784, 59785, 59786, 59787, 59788, 59789, 59790, 59791, 59792]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 3, 2017, 7:21 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59792/
> -----------------------------------------------------------
> 
> (Updated June 3, 2017, 7:21 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When originally added, the configure and install commands were set but
> not used. We use `BUILD_IN_SOURCE` to avoid using `cd`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f 
> 
> 
> Diff: https://reviews.apache.org/r/59792/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message