mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 59774: Removed Autotools to CMake configuration mapping.
Date Sat, 03 Jun 2017 19:27:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59774/
-----------------------------------------------------------

(Updated June 3, 2017, 7:27 p.m.)


Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li.


Bugs: MESOS-7618
    https://issues.apache.org/jira/browse/MESOS-7618


Repository: mesos


Description
-------

While convenient, this mapping was forcing the CMake build to be setup
exactly like the Autotools build, even when it was antithetical to a
proper CMake build system.

Instead, the `docker-build.sh` script now expects a CMake configuration
when the CMake build tool is specified.


Diffs
-----

  support/docker-build.sh d17cc765a11097227f25b1897f61676677f83b87 


Diff: https://reviews.apache.org/r/59774/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message