Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A962C200C8F for ; Fri, 26 May 2017 00:48:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A803B160BD5; Thu, 25 May 2017 22:48:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE8AD160BCA for ; Fri, 26 May 2017 00:48:58 +0200 (CEST) Received: (qmail 28342 invoked by uid 500); 25 May 2017 22:48:58 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28245 invoked by uid 99); 25 May 2017 22:48:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 May 2017 22:48:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8510AC6B35; Thu, 25 May 2017 22:48:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xFcIj-Ni5fFY; Thu, 25 May 2017 22:48:56 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2813A5FB29; Thu, 25 May 2017 22:48:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4F211E01D8; Thu, 25 May 2017 22:48:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 066C0C4005D; Thu, 25 May 2017 22:48:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5381565390908634876==" MIME-Version: 1.0 Subject: Review Request 59582: Made the executor driver drop some messages when not connected. From: Greg Mann To: Anand Mazumdar , Benjamin Mahler , Vinod Kone Cc: Greg Mann , mesos Date: Thu, 25 May 2017 22:48:53 -0000 Message-ID: <20170525224853.10156.62412@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59582/ X-Sender: Greg Mann Reply-To: Greg Mann X-ReviewRequest-Repository: mesos archived-at: Thu, 25 May 2017 22:48:59 -0000 --===============5381565390908634876== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59582/ ----------------------------------------------------------- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. Bugs: MESOS-7542 https://issues.apache.org/jira/browse/MESOS-7542 Repository: mesos Description ------- This patch updates the executor driver to drop RunTaskMessages, FrameworkMessages, and StatusUpdateAcknowledgements when it is not connected to the agent. This facilitates executor reconnect retry logic which is being added to the agent. Diffs ----- src/exec/exec.cpp f36e3707d8804b63ec1ca4e7f16728210f0029de Diff: https://reviews.apache.org/r/59582/diff/1/ Testing ------- Testing details can be found at the end of this chain. Thanks, Greg Mann --===============5381565390908634876==--