Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1E70D200C7D for ; Tue, 16 May 2017 09:22:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1D3DB160BCF; Tue, 16 May 2017 07:22:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F050160BAC for ; Tue, 16 May 2017 09:22:09 +0200 (CEST) Received: (qmail 41785 invoked by uid 500); 16 May 2017 07:22:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 41605 invoked by uid 99); 16 May 2017 07:22:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 07:22:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E58EDC09CF; Tue, 16 May 2017 07:22:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KNxCStqj8ubx; Tue, 16 May 2017 07:22:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 85C815FB70; Tue, 16 May 2017 07:22:06 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D391E0280; Tue, 16 May 2017 07:22:06 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 19C54C40413; Tue, 16 May 2017 07:22:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5594517892437937721==" MIME-Version: 1.0 Subject: Re: Review Request 53840: Metric in the allocator to track latency in running allocations. From: Anindya Sinha To: James Peach , Jiang Yan Xu Cc: Anindya Sinha , mesos Date: Tue, 16 May 2017 07:22:06 -0000 Message-ID: <20170516072206.46245.51718@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anindya Sinha X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53840/ X-Sender: Anindya Sinha References: <20170516062340.37593.35411@reviews-vm2.apache.org> In-Reply-To: <20170516062340.37593.35411@reviews-vm2.apache.org> Reply-To: Anindya Sinha X-ReviewRequest-Repository: mesos archived-at: Tue, 16 May 2017 07:22:10 -0000 --===============5594517892437937721== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/ ----------------------------------------------------------- (Updated May 16, 2017, 7:22 a.m.) Review request for mesos, James Peach and Jiang Yan Xu. Changes ------- Updated docs. Bugs: MESOS-6579 https://issues.apache.org/jira/browse/MESOS-6579 Repository: mesos Description ------- Added a metric 'allocator/mesos/allocation_run_interval_ms' which tracks the latency between scheduling an allocation to an actual allocation run. Diffs (updated) ----- docs/monitoring.md c42afce0a26dc15e033ee1375b7cb23d55be40ab src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394 src/master/allocator/mesos/metrics.hpp ce486eb079dc44bf0bbfad8668426c7ae87c97b3 src/master/allocator/mesos/metrics.cpp ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf Diff: https://reviews.apache.org/r/53840/diff/6/ Changes: https://reviews.apache.org/r/53840/diff/5-6/ Testing ------- All tests passed. Thanks, Anindya Sinha --===============5594517892437937721==--