Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 43780200C7F for ; Wed, 10 May 2017 00:11:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 42036160BC3; Tue, 9 May 2017 22:11:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 88708160BB6 for ; Wed, 10 May 2017 00:11:18 +0200 (CEST) Received: (qmail 20257 invoked by uid 500); 9 May 2017 22:11:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20242 invoked by uid 99); 9 May 2017 22:11:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 May 2017 22:11:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0F7E4C0A13; Tue, 9 May 2017 22:11:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6DexrbmlH0hP; Tue, 9 May 2017 22:11:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 318F85F4A7; Tue, 9 May 2017 22:11:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8D61E002A; Tue, 9 May 2017 22:11:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 91803C401AA; Tue, 9 May 2017 22:11:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6031951901119678842==" MIME-Version: 1.0 Subject: Review Request 59114: Improved error reporting in status update manager. From: Neil Conway To: Vinod Kone Cc: Neil Conway , mesos Date: Tue, 09 May 2017 22:11:15 -0000 Message-ID: <20170509221115.17092.87993@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59114/ X-Sender: Neil Conway Reply-To: Neil Conway X-ReviewRequest-Repository: mesos archived-at: Tue, 09 May 2017 22:11:19 -0000 --===============6031951901119678842== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59114/ ----------------------------------------------------------- Review request for mesos and Vinod Kone. Repository: mesos Description ------- When an I/O operation fails, we should include the error message returned by the I/O operation in the error we return to the caller. Diffs ----- src/slave/status_update_manager.cpp df63a708c70a2f22f3ca7692adfaa847c972c302 Diff: https://reviews.apache.org/r/59114/diff/1/ Testing ------- Visual inspection, `make check`. Thanks, Neil Conway --===============6031951901119678842==--