Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3227455573198922125=="
MIME-Version: 1.0
Subject: Re: Review Request 59012: Implemented passing the secret fetcher to
 registry puller.
From: Vinod Kone <vinodkone@gmail.com>
To: Adam B <adam@mesosphere.io>, Kapil Arya <kapil@mesosphere.io>,
 Jie Yu <yujie.jay@gmail.com>, Chun-Hung Hsiao <chhsiao@mesosphere.io>,
 Vinod Kone <vinodkone@gmail.com>, Till Toenshoff <toenshoff@me.com>
Cc: Gilbert Song <songzihao1990@gmail.com>, mesos <reviews@mesos.apache.org>
Date: Tue, 09 May 2017 00:17:56 -0000
Message-ID: <20170509001756.23035.4821@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Vinod Kone <noreply@reviews.apache.org>
References: <20170505235501.48086.60624@reviews-vm2.apache.org>
In-Reply-To: <20170505235501.48086.60624@reviews-vm2.apache.org>
Reply-To: Vinod Kone <vinodkone@gmail.com>
archived-at: Tue, 09 May 2017 00:18:00 -0000

--===============3227455573198922125==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On May 5, 2017, 11:55 p.m., Chun-Hung Hsiao wrote:
> > Should we use a shared pointer for `SecretResolver` instead of passing a `SecretResolver*` around?

+1. Since provisioner and env isolator are both sharing the pointer, it's probably worth having the containerizer take in a shared pointer instead of raw pointer. cc @karya.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59012/#review174103
-----------------------------------------------------------


On May 5, 2017, 11:16 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59012/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented passing the secret fetcher to registry puller.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp b58baed64480e22f640a4852537f85922ed382ae 
>   src/slave/containerizer/mesos/provisioner/appc/store.hpp 15c79e9401a821e445fbd32b34503e4fb0014d42 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 09a40a5835454bb7519d11bae4a851337a89b935 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp ac9dae8ecbb897b8ff942d11ac70281a63e06831 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp e1abff19c8877ad07900bb2f44deca1cdda41f58 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 7d6c1b93a2c0e265b9344a0fc27f1cf4ed5325f2 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp be45fc59027f176b43b767e9441fd8089ceec7b4 
>   src/slave/containerizer/mesos/provisioner/store.hpp 82a9be64264ae829773c1e2e8a4360f78641cbf6 
>   src/slave/containerizer/mesos/provisioner/store.cpp 7141d63fcf2dbc3fbf00508c7f92945aab014fb2 
> 
> 
> Diff: https://reviews.apache.org/r/59012/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


--===============3227455573198922125==--