Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 53206200C68 for ; Wed, 3 May 2017 22:46:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 51C01160BB5; Wed, 3 May 2017 20:46:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 98130160BA1 for ; Wed, 3 May 2017 22:46:23 +0200 (CEST) Received: (qmail 45261 invoked by uid 500); 3 May 2017 20:46:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45245 invoked by uid 99); 3 May 2017 20:46:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 May 2017 20:46:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D81B188342; Wed, 3 May 2017 20:46:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5m1xpyUOYRac; Wed, 3 May 2017 20:46:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 79FDE5FC9C; Wed, 3 May 2017 20:46:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CCB23E092E; Wed, 3 May 2017 20:46:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A7FB9C4037A; Wed, 3 May 2017 20:46:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6920085987389152829==" MIME-Version: 1.0 Subject: Review Request 58974: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota. From: Neil Conway To: Alexander Rukletsov Cc: Neil Conway , mesos Date: Wed, 03 May 2017 20:46:19 -0000 Message-ID: <20170503204619.10569.44513@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58974/ X-Sender: Neil Conway Reply-To: Neil Conway X-ReviewRequest-Repository: mesos archived-at: Wed, 03 May 2017 20:46:24 -0000 --===============6920085987389152829== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58974/ ----------------------------------------------------------- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7457 https://issues.apache.org/jira/browse/MESOS-7457 Repository: mesos Description ------- Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota. Diffs ----- src/tests/hierarchical_allocator_tests.cpp ebc4868a6b7e2a04cc202a74a4633969ade40aca Diff: https://reviews.apache.org/r/58974/diff/1/ Testing ------- `make check` I wasn't able to repro the flakiness on my local box, but the previous test coding does seem wrong, now that `setQuota` doesn't trigger a batch allocation. Thanks, Neil Conway --===============6920085987389152829==--