mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 58720: Extended the unit test infrastructure in the new Mesos CLI.
Date Mon, 29 May 2017 22:24:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176276
-----------------------------------------------------------



This is still failing for me after the rebase:
```
(mesos-cli) $ mesos
Traceback (most recent call last):
  File "/scratch/klueska/projects/mesos/src/cli_new/bin/main.py", line 25, in <module>
    import cli
  File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 22, in <module>
    from . import constants
ImportError: cannot import name constants
```

Then after fixing this error by removing `from . import constants` from `__init__.py`:

```
(mesos-cli) $ mesos-cli-tests
Traceback (most recent call last):
  File "/scratch/klueska/projects/mesos/src/cli_new/bin/../tests/main.py", line 27, in <module>
    from cli.tests import TestInfrastructure
  File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 21, in <module>
    from . import config
  File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/config.py", line 24, in <module>
    import settings
ImportError: No module named settings
```


src/cli_new/lib/cli/__init__.py
Lines 22 (patched)
<https://reviews.apache.org/r/58720/#comment249644>

    This file doesn't exist, so we can't import it.


- Kevin Klues


On May 29, 2017, 3:27 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
> 
> (Updated May 29, 2017, 3:27 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7283
>     https://issues.apache.org/jira/browse/MESOS-7283
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3 
>   src/cli_new/lib/cli/tests/__init__.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/base.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/constants.py PRE-CREATION 
>   src/cli_new/lib/cli/tests/tests.py PRE-CREATION 
>   src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 
>   src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 
> 
> 
> Diff: https://reviews.apache.org/r/58720/diff/13/
> 
> 
> Testing
> -------
> 
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message