mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.
Date Wed, 24 May 2017 21:32:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59541/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-7552
    https://issues.apache.org/jira/browse/MESOS-7552


Repository: mesos


Description
-------

This test did not pause the clock; hence, batch allocations could occur
at unpredictable times and cause the test to fail.

Fix this by pausing the clock and explicitly advancing it as needed to
trigger batch allocations or other events.


Diffs
-----

  src/tests/master_allocator_tests.cpp 750e030d388d5469399bc79fa723095e62b8f2c5 


Diff: https://reviews.apache.org/r/59541/diff/1/


Testing
-------

`./src/mesos-tests --gtest_filter="MasterAllocatorTest/0.FrameworkExited" --gtest_break_on_failure
--gtest_repeat=5000` # Linux

Without this RR, the test fails within a few hundred iterations.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message