mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 59463: Added test for agent ping timeout during agent recovery.
Date Wed, 24 May 2017 17:55:05 GMT


> On May 24, 2017, 1:27 a.m., Benjamin Mahler wrote:
> > src/tests/slave_recovery_tests.cpp
> > Lines 955 (patched)
> > <https://reviews.apache.org/r/59463/diff/2/?file=1730917#file1730917line955>
> >
> >     Rather than pausing, resuming and pausing again, have you tried leaving the
clock paused for the whole test?

I did try this, but was unable to achieve a successful agent re-registration when the clock
was paused.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59463/#review175888
-----------------------------------------------------------


On May 24, 2017, 5:54 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59463/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7540
>     https://issues.apache.org/jira/browse/MESOS-7540
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new test, `SlaveRecoveryTest.PingTimeoutDuringRecovery`,
> which verifies that the agent will reply to pings from the master while it
> is performing recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 0aa87f534fbc655e3f1aa2ab7f56a1b6be7a8755 
> 
> 
> Diff: https://reviews.apache.org/r/59463/diff/4/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message