mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59481: Added sorter test for allocation queries about inactive clients.
Date Tue, 23 May 2017 20:16:50 GMT


> On May 23, 2017, 3:33 p.m., James Peach wrote:
> > I would find it helpful to have a summary of what this test is trying to do. I gather
that it is demonstrating that even when a client is marked inactive, it's share of resources
is persisted?

Thanks, I added some comments.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59481/#review175795
-----------------------------------------------------------


On May 23, 2017, 8:15 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59481/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This behavior has not changed, but was not covered by the existing
> tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 2389664df401a4579d7a7a218d552d1d1bec5536 
> 
> 
> Diff: https://reviews.apache.org/r/59481/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message