mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.
Date Mon, 22 May 2017 16:56:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------

(Updated May 22, 2017, 4:56 p.m.)


Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.


Bugs: MESOS-7520
    https://issues.apache.org/jira/browse/MESOS-7520


Repository: mesos


Description
-------

Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>'
is not a constant expression because it refers to an incompletely initialized variable`. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829

This patch changes around the `Bytes` class a bit by getting rid of the small classes that
extend `Bytes`.


Diffs
-----

  3rdparty/stout/include/stout/bytes.hpp 98223db50 


Diff: https://reviews.apache.org/r/59413/diff/4/


Testing
-------

`./bootstrap && mkdir build && cd build && ../configure --disable-python
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message