mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 59355: WIP: Improved sorter perf with many inactive clients.
Date Wed, 17 May 2017 23:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59355/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Michael Park.


Repository: mesos


Description
-------

WIP: Improved sorter perf with many inactive clients.


Diffs
-----

  src/master/allocator/sorter/drf/sorter.cpp 26b77f578f3235a8792c72d4575d607cdb2c7de7 


Diff: https://reviews.apache.org/r/59355/diff/1/


Testing
-------

Initial perf testing:

MESOS 1.2.0:
===================
```
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
Using 5000 agents and 6000 frameworks
Added 6000 frameworks in 73.164389ms
Added 5000 agents in 39.148832702secs
allocate() took 31.824026984secs to make 5000 offers with 1200 out of 6000 frameworks suppressing
offers
allocate() took 23.467935579secs to make 5000 offers with 2400 out of 6000 frameworks suppressing
offers
allocate() took 15.528170646secs to make 5000 offers with 3600 out of 6000 frameworks suppressing
offers
allocate() took 7.746030551secs to make 5000 offers with 4800 out of 6000 frameworks suppressing
offers
allocate() took 25.867454ms to make 0 offers with 6000 out of 6000 frameworks suppressing
offers
[       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
(121894 ms)
[----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (121894
ms total)
```

MESOS in master branch:
===================
```
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
Using 5000 agents and 6000 frameworks
Added 6000 frameworks in 282.858346ms
Added 5000 agents in 16.986189021secs
allocate() took 17.262100444secs to make 5000 offers with 1200 out of 6000 frameworks suppressing
offers
allocate() took 17.106477051secs to make 5000 offers with 2400 out of 6000 frameworks suppressing
offers
allocate() took 17.032456469secs to make 5000 offers with 3600 out of 6000 frameworks suppressing
offers
allocate() took 15.375699284secs to make 5000 offers with 4800 out of 6000 frameworks suppressing
offers
allocate() took 323.279937ms to make 0 offers with 6000 out of 6000 frameworks suppressing
offers
[       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
(88780 ms)
[----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (88781
ms total)
```

MESOS in master branch + this patch:
===================
```
[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
Using 5000 agents and 6000 frameworks
Added 6000 frameworks in 290.040808ms
Added 5000 agents in 17.406607193secs
allocate() took 14.893550012secs to make 5000 offers with 1200 out of 6000 frameworks suppressing
offers
allocate() took 12.148378927secs to make 5000 offers with 2400 out of 6000 frameworks suppressing
offers
allocate() took 10.28024964secs to make 5000 offers with 3600 out of 6000 frameworks suppressing
offers
allocate() took 8.455132769secs to make 5000 offers with 4800 out of 6000 frameworks suppressing
offers
allocate() took 298.49347ms to make 0 offers with 6000 out of 6000 frameworks suppressing
offers
[       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
(68181 ms)
[----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (68181
ms total)
```


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message