mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59294: Optionally scale egress bandwidth with CPU.
Date Wed, 17 May 2017 21:14:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/#review175114
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Lines 586-588 (patched)
<https://reviews.apache.org/r/59294/#comment248474>

    Instead of shelling out, i'd say we just introduce support in the nl library. IN fact,
we already have a patch chain starts here to support that
    https://reviews.apache.org/r/45605/



src/slave/flags.cpp
Lines 770-786 (patched)
<https://reviews.apache.org/r/59294/#comment248771>

    This sounds like a heuristic. Any justification why this heuristic? Wondering if label
based solution is better? For instance, the isolator will look for a special label of the
task/executor. The label specifies the egress rate limit which can override the default rate
limit. Something along this line?
    
    Then, the custom logic can be injected into a label decrorator, rather than first class
it here?


- Jie Yu


On May 15, 2017, 8:56 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59294/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 8:56 p.m.)
> 
> 
> Review request for mesos, Dmitry Zhuk, Ilya Pronin, Jie Yu, and Santhosh Kumar Shanmugham.
> 
> 
> Bugs: MESOS-7508
>     https://issues.apache.org/jira/browse/MESOS-7508
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support to isolators/port_mapping for optionally scaling egress bandwidth with CPU
and with minimum and maximum limits.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966

>   src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd 
>   src/slave/flags.cpp bc63a6a4cb6115b4b4d592e67e34045f52b50d4c 
>   src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5

> 
> 
> Diff: https://reviews.apache.org/r/59294/diff/1/
> 
> 
> Testing
> -------
> 
> # added a new test 
> $ make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message