mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 59318: Replace an EXPECT with an ASSERT in master_tests to avoid segfaults.
Date Wed, 17 May 2017 00:34:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59318/#review175183
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58923, 58924, 58925, 58759, 58760, 58999, 59000, 59001, 59318]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 16, 2017, 7:28 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59318/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 7:28 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218 
> 
> 
> Diff: https://reviews.apache.org/r/59318/diff/1/
> 
> 
> Testing
> -------
> 
> Make check with an without the patch.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message