mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Review Request 59202: Ported the net::mac to the Windows Platform.
Date Thu, 11 May 2017 20:15:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59202/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-5938
    https://issues.apache.org/jira/browse/MESOS-5938


Repository: mesos


Description
-------

Note that, on Windows, net::mac takes a MAC address rather than a
network name. See associated changes to net::links for an explanation
of why this is the case.

Just for sanity, even though we take a MAC address as input, we go
ahead and validate the input, validating that the mac address passed
in is actually valid on the current system.


Diffs
-----

  3rdparty/stout/include/stout/mac.hpp 7ed5f38ae4f93e267406254cb2acff201faffe45 
  3rdparty/stout/include/stout/posix/mac.hpp PRE-CREATION 
  3rdparty/stout/include/stout/windows/mac.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/59202/diff/1/


Testing
-------

See final commit for tests performed.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message