mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 58759: Introduced SecretFetcher module interface.
Date Thu, 04 May 2017 23:56:43 GMT


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/module/secretfetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708761#file1708761line17>
> >
> >     secret_fetcher.hpp
> >     
> >     (we have secret_generator.hpp). Let's make sure it's consistent.

I'll update it to secret_fetcher.hpp. However, please note that there is still some inconsistency
here: the module interface is called `SecretGenerator` but the file is named `secret_generator.hpp`.


> On May 4, 2017, 6:25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> >     I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
> 
> Kapil Arya wrote:
>     I am not sure so sure about it because there is nothing in common between `Fetcher`
and `SecretFetcher`. One can think of `SecretFetcher` as more like secret-resolver.
>     
>     Perhaps, next to authentication/secret_generator.hpp would be slightly better, but
then it doesn't have much to do with authentication either.
> 
> Jie Yu wrote:
>     OK, i am fine with secret/fetcher.hpp. Make sure it's consistent with the cpp file.

I am not sure what you mean by "Make sure it's consistent with the cpp file"?


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
-----------------------------------------------------------


On May 4, 2017, 4:06 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58759/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 4:06 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced SecretFetcher module interface.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/secretfetcher.hpp PRE-CREATION 
>   include/mesos/secret/fetcher.hpp PRE-CREATION 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 
> 
> 
> Diff: https://reviews.apache.org/r/58759/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message