Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0D7AE200C60 for ; Mon, 24 Apr 2017 21:13:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 08FCA160B99; Mon, 24 Apr 2017 19:13:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 504CD160B93 for ; Mon, 24 Apr 2017 21:13:07 +0200 (CEST) Received: (qmail 92840 invoked by uid 500); 24 Apr 2017 19:13:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 92828 invoked by uid 99); 24 Apr 2017 19:13:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Apr 2017 19:13:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DBF141A0144; Mon, 24 Apr 2017 19:13:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id FapdOsqDjzSJ; Mon, 24 Apr 2017 19:13:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 158005FC4D; Mon, 24 Apr 2017 19:13:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 79F35E017A; Mon, 24 Apr 2017 19:13:03 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3CD39C40361; Mon, 24 Apr 2017 19:13:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3863867700388338138==" MIME-Version: 1.0 Subject: Re: Review Request 58357: Support more test frameworks in test-upgrade script. From: Greg Mann To: Xiaojian Huang , Anand Mazumdar , Greg Mann Cc: Zhitao Li , Mesos Reviewbot , mesos Date: Mon, 24 Apr 2017 19:13:03 -0000 Message-ID: <20170424191303.17467.36147@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58357/ X-Sender: Greg Mann References: <20170420214022.24123.1215@reviews-vm2.apache.org> In-Reply-To: <20170420214022.24123.1215@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos archived-at: Mon, 24 Apr 2017 19:13:08 -0000 --===============3863867700388338138== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 20, 2017, 9:40 p.m., Greg Mann wrote: > > support/test-upgrade.py > > Lines 298-302 (patched) > > > > > > Would it be possible to allow the user to exclude more than one at a time? I would also be find with the user specifying explicitly a list of the frameworks they _do_ want to run. > > Zhitao Li wrote: > Yes I can make this a comma separated list. > > Do you think we need both of `excluding tests` and `only run tests`? I think just one or the other is fine. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/#review172551 ----------------------------------------------------------- On April 19, 2017, 4:28 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58357/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 4:28 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > This patch added support to java and python based test framework in > `test-upgrade.py` script. > > > Diffs > ----- > > support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 > > > Diff: https://reviews.apache.org/r/58357/diff/3/ > > > Testing > ------- > > Ran this on all three languages options for cpp, java and python. > > > Thanks, > > Zhitao Li > > --===============3863867700388338138==--