Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============9161591163064594921=="
MIME-Version: 1.0
Subject: Re: Review Request 58512: Avoid a crash in HTTP decoder.
From: Anand Mazumdar <anand@apache.org>
To: Anand Mazumdar <anand@apache.org>, James Peach <jpeach@apache.org>,
 Jiang Yan Xu <yan@jxu.me>
Cc: Anindya Sinha <anindya_sinha@apple.com>, mesos <reviews@mesos.apache.org>
Date: Thu, 20 Apr 2017 16:06:55 -0000
Message-ID: <20170420160655.24123.58074@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Anand Mazumdar <noreply@reviews.apache.org>
References: <20170419160209.32394.14901@reviews-vm2.apache.org>
In-Reply-To: <20170419160209.32394.14901@reviews-vm2.apache.org>
Reply-To: Anand Mazumdar <anand@apache.org>
archived-at: Thu, 20 Apr 2017 16:07:00 -0000

--===============9161591163064594921==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58512/#review172504
-----------------------------------------------------------


3rdparty/libprocess/src/decoder.hpp
Lines 208 (patched)
<https://reviews.apache.org/r/58512/#comment245597>

    hmm, these seem not related to the review i.e., avoiding the crash. Can you create a separate patch with these changes and mark this as dependent on it?
    
    Good catch!


3rdparty/libprocess/src/decoder.hpp
Lines 715 (patched)
<https://reviews.apache.org/r/58512/#comment245598>

    set `decoder->failed=true` here? If it's already set earlier, add an explicit invariant check here before this line?


3rdparty/libprocess/src/decoder.hpp
Lines 1017 (patched)
<https://reviews.apache.org/r/58512/#comment245600>

    Ditto as above.


- Anand Mazumdar


On April 19, 2017, 4:02 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58512/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 4:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, James Peach, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7400
>     https://issues.apache.org/jira/browse/MESOS-7400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the callback `on_headers_complete()` fails, the decoder's writer
> object is `None()`. So, when the callback `on_message_complete()` is
> called, we should not crash in that case.
> Note that the `CHECK(decoder->writer)` is valid for the callback
> `on_body()` is valid since this callback is called only on a success
> in `on_headers_complete()` callback.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp c0efef571815752cc28e5a0dc7a07adc82bb31d5 
> 
> 
> Diff: https://reviews.apache.org/r/58512/diff/2/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


--===============9161591163064594921==--