Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6293C200C4E for ; Fri, 7 Apr 2017 02:53:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 61399160B9F; Fri, 7 Apr 2017 00:53:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A8C18160B91 for ; Fri, 7 Apr 2017 02:53:30 +0200 (CEST) Received: (qmail 10819 invoked by uid 500); 7 Apr 2017 00:53:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 10807 invoked by uid 99); 7 Apr 2017 00:53:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 00:53:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 419D9C2454; Fri, 7 Apr 2017 00:53:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.001 X-Spam-Level: *** X-Spam-Status: No, score=3.001 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BCpJOvupyuXQ; Fri, 7 Apr 2017 00:53:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F0CB45FC73; Fri, 7 Apr 2017 00:53:26 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6E032E0185; Fri, 7 Apr 2017 00:53:26 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 26258C406CE; Fri, 7 Apr 2017 00:53:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7935805950904013052==" MIME-Version: 1.0 Subject: Re: Review Request 57896: Renamed config.py to settings.py in the new CLI. From: Joseph Wu To: Kevin Klues Cc: Armand Grillet , Joseph Wu , mesos Date: Fri, 07 Apr 2017 00:53:25 -0000 Message-ID: <20170407005325.2051.11485@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20170327115618.41782.43296@reviews-vm2.apache.org> X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57896/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20170327115618.41782.43296@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/cli_new/bin/config.py X-ReviewBoard-Diff-For: src/cli_new/bin/settings.py X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos Sender: Joseph Wu archived-at: Fri, 07 Apr 2017 00:53:31 -0000 --===============7935805950904013052== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/#review171302 ----------------------------------------------------------- Ship it! Ship It! - Joseph Wu On March 27, 2017, 4:56 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57896/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 4:56 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7269 > https://issues.apache.org/jira/browse/MESOS-7269 > > > Repository: mesos > > > Description > ------- > > Change made due to the upcoming introduction of a `config` plugin. > > > Diffs > ----- > > src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 > src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d > > > Diff: https://reviews.apache.org/r/57896/diff/3/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is correct. > > > Thanks, > > Armand Grillet > > --===============7935805950904013052==--