Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7AF78200C5B for ; Wed, 5 Apr 2017 01:06:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7970A160BA1; Tue, 4 Apr 2017 23:06:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C10A0160B90 for ; Wed, 5 Apr 2017 01:06:12 +0200 (CEST) Received: (qmail 28522 invoked by uid 500); 4 Apr 2017 23:06:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 28511 invoked by uid 99); 4 Apr 2017 23:06:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2017 23:06:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5969EC0040; Tue, 4 Apr 2017 23:06:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2f3_k2UU40iL; Tue, 4 Apr 2017 23:06:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1D3F25F1A0; Tue, 4 Apr 2017 23:06:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BCB67E0041; Tue, 4 Apr 2017 23:06:09 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AC797C40969; Tue, 4 Apr 2017 23:06:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4122614844107904958==" MIME-Version: 1.0 Subject: Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`. From: Joseph Wu To: Li Li , Jeff Coffler , John Kordich , Joseph Wu , Michael Park Cc: mesos Date: Tue, 04 Apr 2017 23:06:09 -0000 Message-ID: <20170404230609.22168.74879@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58160/ X-Sender: Joseph Wu X-ReviewBoard-ShipIt: 1 References: <20170403212100.29826.63802@reviews-vm2.apache.org> In-Reply-To: <20170403212100.29826.63802@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos archived-at: Tue, 04 Apr 2017 23:06:13 -0000 --===============4122614844107904958== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58160/#review171066 ----------------------------------------------------------- Ship it! Ship It! - Joseph Wu On April 3, 2017, 2:21 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58160/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 2:21 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This macro was not working because they are semantically different: > a single binary versus a binary with arguments. > > > Diffs > ----- > > 3rdparty/stout/include/stout/gtest.hpp 763fd7b06b240c4a2e1eeb6a283eb192e5a88df9 > > > Diff: https://reviews.apache.org/r/58160/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============4122614844107904958==--