Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E469F200C4C for ; Tue, 4 Apr 2017 18:10:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E30DF160B90; Tue, 4 Apr 2017 16:10:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 32D20160B81 for ; Tue, 4 Apr 2017 18:10:41 +0200 (CEST) Received: (qmail 87406 invoked by uid 500); 4 Apr 2017 16:10:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87338 invoked by uid 99); 4 Apr 2017 16:10:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Apr 2017 16:10:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BE88DC00BC; Tue, 4 Apr 2017 16:10:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id EaJm-41ZWRK3; Tue, 4 Apr 2017 16:10:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A969B5F570; Tue, 4 Apr 2017 16:10:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5004DE0185; Tue, 4 Apr 2017 16:10:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 02223C40481; Tue, 4 Apr 2017 16:10:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6493407486485885386==" MIME-Version: 1.0 Subject: Re: Review Request 58173: Fixed 'CombinedAuthenticator' to avoid an extra copy. From: Mesos Reviewbot To: Anand Mazumdar , Vinod Kone Cc: Mesos Reviewbot , Greg Mann , mesos Date: Tue, 04 Apr 2017 16:10:37 -0000 Message-ID: <20170404161037.22167.86725@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58173/ X-Sender: Mesos Reviewbot References: <20170404141116.29825.60531@reviews-vm2.apache.org> In-Reply-To: <20170404141116.29825.60531@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos archived-at: Tue, 04 Apr 2017 16:10:42 -0000 --===============6493407486485885386== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58173/#review170975 ----------------------------------------------------------- Patch looks great! Reviews applied: [58173] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 4, 2017, 2:11 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58173/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 2:11 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch adds a missing call to `std::move` in the constructor > for `CombinedAuthenticatorProcess` to avoid an unnecessary copy. > > > Diffs > ----- > > src/authentication/http/combined_authenticator.cpp c734e7672e96087fa715501cfc594a0165f5bce7 > > > Diff: https://reviews.apache.org/r/58173/diff/1/ > > > Testing > ------- > > `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"` > > > Thanks, > > Greg Mann > > --===============6493407486485885386==--