mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.
Date Wed, 26 Apr 2017 23:33:42 GMT


> On April 26, 2017, 7:16 p.m., Neil Conway wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 811 (patched)
> > <https://reviews.apache.org/r/58640/diff/1/?file=1697732#file1697732line811>
> >
> >     Wouldn't `path::join` be preferrable here?
> 
> Chun-Hung Hsiao wrote:
>     Let me open a new PR to fix this.

Fixed in https://reviews.apache.org/r/58766/.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58640/#review173079
-----------------------------------------------------------


On April 22, 2017, 1:56 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58640/
> -----------------------------------------------------------
> 
> (Updated April 22, 2017, 1:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7280
>     https://issues.apache.org/jira/browse/MESOS-7280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created a non-empty file 'abc' under the agent's work directory, which
> is linked by the symlink '/xyz' in the 2nd layer of the testing image.
> This file should not be overwritten by the empty file '/xyz' in the 3rd
> layer. Please see the following link for more details:
>   https://hub.docker.com/r/chhsiao/overwrite/
> The testing image is updated in a way that it is compatible to the
> previous Overwrite test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp c26e1f9b093fda66f14e474006d8148c0b9f3245

> 
> 
> Diff: https://reviews.apache.org/r/58640/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make test
> Manually tested on commit bc12a58 to make sure that the 'abc' becomes empty in the unpatched
copy backend.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message