mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58557: Print failure reason when socket accept failed.
Date Mon, 24 Apr 2017 23:59:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58557/#review172875
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp
Lines 950-951 (original), 950-954 (patched)
<https://reviews.apache.org/r/58557/#comment245889>

    how about
    
    ```
    } else {
      LOG(ERROR) << "Failed to accept socket: " 
                 << (socket.isFailed() ? socket.failure() : "future discarded");
    }
    ```


- Vinod Kone


On April 20, 2017, 9:35 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58557/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 9:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Print failure reason when socket accept failed.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 92efa91 
> 
> 
> Diff: https://reviews.apache.org/r/58557/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message