mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 58357: Support more test frameworks in test-upgrade script.
Date Thu, 20 Apr 2017 21:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58357/#review172551
-----------------------------------------------------------



Tested this out; works great!! Just a couple small things below.


support/test-upgrade.py
Lines 298-302 (patched)
<https://reviews.apache.org/r/58357/#comment245652>

    Would it be possible to allow the user to exclude more than one at a time? I would also
be find with the user specifying explicitly a list of the frameworks they _do_ want to run.



support/test-upgrade.py
Lines 325-326 (patched)
<https://reviews.apache.org/r/58357/#comment245653>

    Could you add an extra newline or two of logging at the end of each iteration? It's a
bit hard to read the logging output since there are no newlines between the end of each framework
run.


- Greg Mann


On April 19, 2017, 4:28 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58357/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 4:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Greg Mann.
> 
> 
> Bugs: MESOS-7228
>     https://issues.apache.org/jira/browse/MESOS-7228
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added support to java and python based test framework in
> `test-upgrade.py` script.
> 
> 
> Diffs
> -----
> 
>   support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45 
> 
> 
> Diff: https://reviews.apache.org/r/58357/diff/3/
> 
> 
> Testing
> -------
> 
> Ran this on all three languages options for cpp, java and python.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message