mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.
Date Wed, 19 Apr 2017 18:18:21 GMT


> On April 18, 2017, 8:27 p.m., Jeff Coffler wrote:
> > This looks okay. But again: You didn't fill out anything for testing, leading me
to believe that no testing was done.
> > 
> > Please clarify the testing that you completed here, so I can understand that. Thanks.

Please see the last patch in the chain for testing.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58446/#review172261
-----------------------------------------------------------


On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58446/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 2:03 a.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reuse the variable rather than hardcode it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 
> 
> 
> Diff: https://reviews.apache.org/r/58446/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message