mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58465: Fixed alicloud unit test for limited timeout.
Date Mon, 17 Apr 2017 07:16:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58465/#review172074
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/provisioner_docker_tests.cpp
Line 530 (original), 535 (patched)
<https://reviews.apache.org/r/58465/#comment245154>

    Can you use Minutes(3) here?


- Jie Yu


On April 15, 2017, 12:21 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58465/
> -----------------------------------------------------------
> 
> (Updated April 15, 2017, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Chun-Hung Hsiao, Jie Yu, Joseph Wu, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Alicloud server is in Asia. We parameterized the unit test
> `ROOT_INTERNET_CURL_SimpleCommand` to test different registry with
> unifed containerizer. Longer `executor_registration_timeout` should
> be given to make sure the image download is not impacted by network
> legacy.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp b0a4d21a26e084d72b915156e9408826252ef083

> 
> 
> Diff: https://reviews.apache.org/r/58465/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message