mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58287: Print corresponding address when socket shutdown.
Date Fri, 14 Apr 2017 19:23:16 GMT


> On April 12, 2017, 6:39 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp
> > Lines 2362 (patched)
> > <https://reviews.apache.org/r/58287/diff/2/?file=1689528#file1689528line2362>
> >
> >     What if socket.address returns an Error? Let's not print the address if it is
an error:
> >     
> >     ```
> >     Try<network::Address> socketAddress = socket.address();
> >     
> >     LOG(ERROR) << "Failed to shutdown socket with fd " << socket.get()
<< ", address "
> >                << (socketAddress.isSome() ? stringify(socketAddress.get())
: "N/A")
> >                << ": " << shutdown.error();
> >     ```

Marking this issue and the below one as "fixed". Andy, for future reference once you fix an
issue please mark it as fixed.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58287/#review171772
-----------------------------------------------------------


On April 13, 2017, 12:44 p.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 12:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Print corresponding address when socket shutdown.
> Default just print socket 'fd',it's not convenient
> to find corresponding address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 92efa91 
> 
> 
> Diff: https://reviews.apache.org/r/58287/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> File Attachments
> ----------------
> 
> process.patch
>   https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message