mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.
Date Fri, 14 Apr 2017 16:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58137/#review172005
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57896, 57951, 58381, 57952, 58137]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 12, 2017, 9:21 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58137/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:21 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This command displays the contents of the user-defined config.toml file.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7

> 
> 
> Diff: https://reviews.apache.org/r/58137/diff/6/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message