mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58125: Stout: Added stringify for std::wstring.
Date Tue, 04 Apr 2017 23:10:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58125/#review171069
-----------------------------------------------------------


Ship it!





3rdparty/stout/include/stout/stringify.hpp
Lines 47-48 (patched)
<https://reviews.apache.org/r/58125/#comment243913>

    As Benjamin suggested, I'll make this into an override (rather than a template specialization)
before committing so that we can take a `const &` instead of a `const`.


- Joseph Wu


On March 31, 2017, 9:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58125/
> -----------------------------------------------------------
> 
> (Updated March 31, 2017, 9:32 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-5418
>     https://issues.apache.org/jira/browse/MESOS-5418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added stringify for std::wstring.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/stringify.hpp e9588d8d940046791794100c53469288656a14f0

> 
> 
> Diff: https://reviews.apache.org/r/58125/diff/2/
> 
> 
> Testing
> -------
> 
> Testing done later in chain.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message