mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58160: Stout: Removed `TRUE_COMMAND`.
Date Tue, 04 Apr 2017 23:06:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58160/#review171066
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On April 3, 2017, 2:21 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58160/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 2:21 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This macro was not working because they are semantically different:
> a single binary versus a binary with arguments.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/gtest.hpp 763fd7b06b240c4a2e1eeb6a283eb192e5a88df9 
> 
> 
> Diff: https://reviews.apache.org/r/58160/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message