Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FD79200C39 for ; Thu, 16 Mar 2017 17:53:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5E6FA160B72; Thu, 16 Mar 2017 16:53:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AC2E4160B78 for ; Thu, 16 Mar 2017 17:53:20 +0100 (CET) Received: (qmail 8909 invoked by uid 500); 16 Mar 2017 16:53:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 8897 invoked by uid 99); 16 Mar 2017 16:53:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 16:53:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3CC1C1809F9; Thu, 16 Mar 2017 16:53:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id YmyP6JM68CdP; Thu, 16 Mar 2017 16:53:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EFA675FD3B; Thu, 16 Mar 2017 16:53:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD002E040D; Thu, 16 Mar 2017 16:53:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 95B6CC4047C; Thu, 16 Mar 2017 16:53:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7964840247370403122==" MIME-Version: 1.0 Subject: Re: Review Request 57167: Updated quota handler logic for hierarchical roles. From: Neil Conway To: Michael Park Cc: Neil Conway , Mesos Reviewbot , Benjamin Mahler , Jay Guo , mesos Date: Thu, 16 Mar 2017 16:53:15 -0000 Message-ID: <20170316165315.1083.49954@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57167/ X-Sender: Neil Conway References: <20170310220349.56876.69883@reviews-vm2.apache.org> In-Reply-To: <20170310220349.56876.69883@reviews-vm2.apache.org> Reply-To: Neil Conway X-ReviewRequest-Repository: mesos archived-at: Thu, 16 Mar 2017 16:53:21 -0000 --===============7964840247370403122== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ ----------------------------------------------------------- (Updated March 16, 2017, 4:53 p.m.) Review request for mesos and Michael Park. Changes ------- Fix typo in comment. Repository: mesos Description ------- The quota'd resources for a nested role are "included" within the quota'd resources for that role's parent. Hence, the quota of a node must always be greater than or equal to the sum of the quota'd resources of that role's children. When creating and removing quota, we must ensure that this invariant is not violated. When computing the cluster capacity heuristic, we must ensure that we do not "double-count" quota'd resources: e.g., if the cluster has a total capacity of 100 CPUs, role "x" has a quota guarantee of 80 CPUs, and role "x/y" has a quota guarantee of 40 CPUs, this does NOT violate the cluster capacity heuristic. Diffs (updated) ----- src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 src/tests/hierarchical_allocator_tests.cpp dce619ec49db480685deb1bf8f7faeebe02e25b5 src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 Diff: https://reviews.apache.org/r/57167/diff/5/ Changes: https://reviews.apache.org/r/57167/diff/4-5/ Testing ------- `make check` Thanks, Neil Conway --===============7964840247370403122==--