Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9A45D200C39 for ; Thu, 16 Mar 2017 17:04:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 98F7F160B7A; Thu, 16 Mar 2017 16:04:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B1B16160B78 for ; Thu, 16 Mar 2017 17:04:03 +0100 (CET) Received: (qmail 88636 invoked by uid 500); 16 Mar 2017 16:04:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 88621 invoked by uid 99); 16 Mar 2017 16:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Mar 2017 16:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3B70C18F163; Thu, 16 Mar 2017 16:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id nWhi2s9LAYwW; Thu, 16 Mar 2017 16:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id F3C775F238; Thu, 16 Mar 2017 16:04:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 18615E026E; Thu, 16 Mar 2017 16:03:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E2DAAC4047A; Thu, 16 Mar 2017 16:03:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8059410530364555681==" MIME-Version: 1.0 Subject: Re: Review Request 56217: Added support for general checks to default executor. From: Alexander Rukletsov To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone Cc: Alexander Rukletsov , mesos Date: Thu, 16 Mar 2017 16:03:58 -0000 Message-ID: <20170316160358.1083.14011@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56217/ X-Sender: Alexander Rukletsov References: <20170215143207.13057.12253@reviews.apache.org> In-Reply-To: <20170215143207.13057.12253@reviews.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos archived-at: Thu, 16 Mar 2017 16:04:04 -0000 --===============8059410530364555681== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Feb. 15, 2017, 2:32 p.m., Gastón Kleiman wrote: > > src/launcher/default_executor.cpp > > Lines 931 (patched) > > > > > > I think that it'd be useful to also log the exit status/http status code. > > > > Maybe the best way would be to implement the `ostream::operator<<` for `CheckStatusInfo`? Good idea. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/#review165698 ----------------------------------------------------------- On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56217/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:57 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > > > Diff: https://reviews.apache.org/r/56217/diff/3/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > > --===============8059410530364555681==--