Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7720D200C46 for ; Wed, 15 Mar 2017 04:26:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 75CE7160B89; Wed, 15 Mar 2017 03:26:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF6CB160B7E for ; Wed, 15 Mar 2017 04:26:34 +0100 (CET) Received: (qmail 65253 invoked by uid 500); 15 Mar 2017 03:26:34 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 65242 invoked by uid 99); 15 Mar 2017 03:26:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 03:26:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 542AEC1207; Wed, 15 Mar 2017 03:26:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.701 X-Spam-Level: **** X-Spam-Status: No, score=4.701 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xybw0KoLmhhK; Wed, 15 Mar 2017 03:26:32 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C9E025F296; Wed, 15 Mar 2017 03:26:31 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9ECB6E0051; Wed, 15 Mar 2017 03:26:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 70473C40985; Wed, 15 Mar 2017 03:26:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8350167188665327920==" MIME-Version: 1.0 Subject: Re: Review Request 57340: Remove adjustment code within Resources::apply. From: Jay Guo To: Benjamin Mahler Cc: Mesos Reviewbot , Jay Guo , mesos Date: Wed, 15 Mar 2017 03:26:22 -0000 Message-ID: <20170315032622.7928.54482@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jay Guo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57340/ X-Sender: Jay Guo References: <20170314173955.7929.99772@reviews-vm2.apache.org> In-Reply-To: <20170314173955.7929.99772@reviews-vm2.apache.org> Reply-To: Jay Guo X-ReviewRequest-Repository: mesos archived-at: Wed, 15 Mar 2017 03:26:35 -0000 --===============8350167188665327920== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ ----------------------------------------------------------- (Updated March 15, 2017, 11:26 a.m.) Review request for mesos and Benjamin Mahler. Changes ------- rebase Bugs: MESOS-7048 https://issues.apache.org/jira/browse/MESOS-7048 Repository: mesos Description ------- Remove adjustment code within Resources::apply. Diffs (updated) ----- src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 src/common/resources.cpp 388e3ef3eabea0dd8d1300e56d493b92b70c75e3 src/master/allocator/mesos/hierarchical.cpp 37fb7a62ef95c2f6e5a9e9a4ab49260332e2b03b src/master/master.cpp d43350d08ddd14fb7ba2a79c899abda6a864038c src/tests/resources_tests.cpp 5ffc9e7111c91157b79a38a1cbd8d58a0565e450 src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463 Diff: https://reviews.apache.org/r/57340/diff/3/ Changes: https://reviews.apache.org/r/57340/diff/2-3/ Testing ------- WIP Thanks, Jay Guo --===============8350167188665327920==--