Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EC51C200C28 for ; Mon, 13 Mar 2017 08:28:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EAD83160B6C; Mon, 13 Mar 2017 07:28:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 40600160B60 for ; Mon, 13 Mar 2017 08:28:04 +0100 (CET) Received: (qmail 62726 invoked by uid 500); 13 Mar 2017 07:28:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 62715 invoked by uid 99); 13 Mar 2017 07:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 07:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A9F361A9596; Mon, 13 Mar 2017 07:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id BvtvxiJz9PEH; Mon, 13 Mar 2017 07:28:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BFA655F649; Mon, 13 Mar 2017 07:28:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 88D62E026E; Mon, 13 Mar 2017 07:27:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 59EA2C40155; Mon, 13 Mar 2017 07:27:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3478206239890486171==" MIME-Version: 1.0 Subject: Re: Review Request 57472: Removing deprecated ACLs `SetQuota` and `RemoveQuota`. From: Alexander Rojas To: Benjamin Bannier , Adam B Cc: mesos , Alexander Rojas Date: Mon, 13 Mar 2017 07:27:59 -0000 Message-ID: <20170313072759.60512.85484@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rojas X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57472/ X-Sender: Alexander Rojas References: <20170310085057.767.91667@reviews-vm2.apache.org> In-Reply-To: <20170310085057.767.91667@reviews-vm2.apache.org> Reply-To: Alexander Rojas X-ReviewRequest-Repository: mesos archived-at: Mon, 13 Mar 2017 07:28:05 -0000 --===============3478206239890486171== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 10, 2017, 9:50 a.m., Adam B wrote: > > CHANGELOG > > Lines 6 (patched) > > > > > > Please mention this in the docs/upgrades.md table as well. > > Benjamin Bannier wrote: > Did you forget to push the update fixing this? What do you mean, it is in this patch. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/#review168589 ----------------------------------------------------------- On March 10, 2017, 10:16 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57472/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 10:16 a.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation > more than six months ago, where they were replaced for the more > convenient `UpdateQuota` ACL. The deprecation cycle for these actions > is finally due while at the same time removing will make easier to > implement the hierarchical role feature in a generic way. > > > Diffs > ----- > > CHANGELOG 0a4e1dd52f9197151c5ef4318579ffa4e9bcf0ee > docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 > include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 > src/authorizer/local/authorizer.cpp 2227b241eab1606815fa6464e3d6b1345624fd22 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 > src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 > src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 > > > Diff: https://reviews.apache.org/r/57472/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > > --===============3478206239890486171==--