Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4D729200C30 for ; Tue, 7 Mar 2017 21:39:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4C235160B68; Tue, 7 Mar 2017 20:39:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 96CA7160B65 for ; Tue, 7 Mar 2017 21:39:07 +0100 (CET) Received: (qmail 42851 invoked by uid 500); 7 Mar 2017 20:39:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 42840 invoked by uid 99); 7 Mar 2017 20:39:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 20:39:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0B369C1416; Tue, 7 Mar 2017 20:39:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cPd50ktv-ICi; Tue, 7 Mar 2017 20:39:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E4C0F5F3BC; Tue, 7 Mar 2017 20:39:04 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6C804E0041; Tue, 7 Mar 2017 20:39:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5C927C41201; Tue, 7 Mar 2017 20:39:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4863957416452884398==" MIME-Version: 1.0 Subject: Re: Review Request 56208: Updated checks library with general check support. From: Alexander Rukletsov To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Vinod Kone Cc: Alexander Rukletsov , mesos Date: Tue, 07 Mar 2017 20:39:04 -0000 Message-ID: <20170307203904.19287.26940@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Alexander Rukletsov X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56208/ X-Sender: Alexander Rukletsov References: <20170301125040.40980.83456@reviews-vm2.apache.org> In-Reply-To: <20170301125040.40980.83456@reviews-vm2.apache.org> Reply-To: Alexander Rukletsov X-ReviewRequest-Repository: mesos archived-at: Tue, 07 Mar 2017 20:39:08 -0000 --===============4863957416452884398== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56208/ ----------------------------------------------------------- (Updated March 7, 2017, 8:39 p.m.) Review request for mesos, Gastón Kleiman and Vinod Kone. Bugs: MESOS-6906 https://issues.apache.org/jira/browse/MESOS-6906 Repository: mesos Description ------- Add support for general checks, i.e. defined by CheckInfo, in checking library. A general check can be either an command or an HTTP request. The library performs the requested check at the specified interval and sends the result to the framework via a task status update. If the current result is the same as the previous result, no status update is sent. Diffs (updated) ----- src/checks/checker.hpp dc293f3d3613dec716510d269829f8a6f406c277 src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 Diff: https://reviews.apache.org/r/56208/diff/8/ Changes: https://reviews.apache.org/r/56208/diff/7-8/ Testing ------- https://reviews.apache.org/r/56213/ Thanks, Alexander Rukletsov --===============4863957416452884398==--