Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A233E200C30 for ; Tue, 7 Mar 2017 16:51:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A0C1E160B68; Tue, 7 Mar 2017 15:51:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8485160B5F for ; Tue, 7 Mar 2017 16:51:26 +0100 (CET) Received: (qmail 217 invoked by uid 500); 7 Mar 2017 15:51:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 206 invoked by uid 99); 7 Mar 2017 15:51:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 15:51:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6C8ABC0C0D; Tue, 7 Mar 2017 15:51:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.498 X-Spam-Level: ***** X-Spam-Status: No, score=5.498 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, SUSPICIOUS_RECIPS=2.497, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id QzdYMhM4qMh1; Tue, 7 Mar 2017 15:51:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5B5F35F1F4; Tue, 7 Mar 2017 15:51:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 34CCFE0041; Tue, 7 Mar 2017 15:51:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 03DEDC41201; Tue, 7 Mar 2017 15:51:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3467367979386445968==" MIME-Version: 1.0 Subject: Re: Review Request 56667: Added support for JSON Web Tokens. From: Jan Schlicht To: Greg Mann , Alexander Rojas Cc: Mesos Reviewbot , Jan Schlicht , mesos Date: Tue, 07 Mar 2017 15:51:21 -0000 Message-ID: <20170307155121.19286.51761@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jan Schlicht X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56667/ X-Sender: Jan Schlicht References: <20170306233338.40992.65826@reviews-vm2.apache.org> In-Reply-To: <20170306233338.40992.65826@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/tests/jwt_tests.cpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/include/process/jwt.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/src/jwt.cpp Reply-To: Jan Schlicht X-ReviewRequest-Repository: mesos archived-at: Tue, 07 Mar 2017 15:51:27 -0000 --===============3467367979386445968== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 7, 2017, 12:33 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 169 (patched) > > > > > > Do you think `parse_component` would be a better name for this? But it's also base64-decoding the component. Of course, in addition to parsing JSON. How about `decode_and_parse`? - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review168040 ----------------------------------------------------------- On March 6, 2017, 3:53 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56667/ > ----------------------------------------------------------- > > (Updated March 6, 2017, 3:53 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > JSON Web Tokens can be used to create claim-based access tokens and is > typically used for HTTP authentication. > This implementation is intended for internal use, e.g. Mesos is supposed > to only parse tokens that it also created. It doesn't fully comply with > RFC 7519. Currently the only supported cryptographic algorithm is HMAC > with SHA-256. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION > 3rdparty/libprocess/src/jwt.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56667/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > > --===============3467367979386445968==--