Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1574653834983739392=="
MIME-Version: 1.0
Subject: Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.
From: Joris Van Remoortere <joris.van.remoortere@gmail.com>
To: Jie Yu <yujie.jay@gmail.com>, Gilbert Song <songzihao1990@gmail.com>
Cc: Joris Van Remoortere <joris.van.remoortere@gmail.com>,
 Srinivas Brahmaroutu <srbrahma@us.ibm.com>, mesos <reviews@mesos.apache.org>
Date: Wed, 01 Mar 2017 18:22:31 -0000
Message-ID: <20170301182231.39251.50944@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Joris Van Remoortere <noreply@reviews.apache.org>
References: <20161016175849.10799.36076@reviews.apache.org>
In-Reply-To: <20161016175849.10799.36076@reviews.apache.org>
Reply-To: Joris Van Remoortere <joris.van.remoortere@gmail.com>
archived-at: Wed, 01 Mar 2017 18:22:35 -0000

--===============1574653834983739392==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/#review167397
-----------------------------------------------------------


Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50959/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
>     https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> AppcFetcherPlugin returns a '.aci' file of a container image.
> 
> Fetch supports all three modes that 'rkt fetch' supports, fetch with
> meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
> location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
> registry ex: 'docker://hello-world'.
> 
> Added new fetched plugin for Appc fetch algorithm. The new
> AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
> fetch a container image into a store specified at a directory location
> using 'rkt fetch' command and method 'rktExport' exports the image
> fetched into the directory location as a '.aci' file that is in tar
> file format, usinf 'rkt image export' command.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 
>   src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
>   src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
>   src/uri/fetchers/rkt.hpp PRE-CREATION 
>   src/uri/fetchers/rkt.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50959/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


--===============1574653834983739392==--