mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58030: Added support for COMMAND checks to the default executor.
Date Wed, 29 Mar 2017 18:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58030/#review170441
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57644, 57648, 56288, 55901, 57645, 57646, 57647, 57854, 57912, 58030]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 29, 2017, 4:39 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58030/
> -----------------------------------------------------------
> 
> (Updated March 29, 2017, 4:39 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7277
>     https://issues.apache.org/jira/browse/MESOS-7277
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for COMMAND checks to the default executor.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp e8af3160c9fd52ec20acf41b86bade50f4539fb1 
>   src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf 
>   src/launcher/default_executor.cpp 606fd9c164052fe8d168969bbb05f6ec99180d3b 
>   src/tests/check_tests.cpp 16f1c07e109e24d475ad593ef1992dfb9f482ba6 
> 
> 
> Diff: https://reviews.apache.org/r/58030/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` under Fedora 24 and macOS including the 4 new tests
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message