mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 56367: Windows: Stout: Shim `os::killtree` to terminate job objects.
Date Mon, 27 Mar 2017 22:12:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56367/
-----------------------------------------------------------

(Updated March 27, 2017, 10:12 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Changes
-------

Updated for `JobObjectManager` changes.


Summary (updated)
-----------------

Windows: Stout: Shim `os::killtree` to terminate job objects.


Bugs: MESOS-6892
    https://issues.apache.org/jira/browse/MESOS-6892


Repository: mesos


Description (updated)
-------

On Windows, a "process tree" is in fact a job object. Thus, the
implementation of `os::killtree` on Windows is a shim which terminates
the job object corresponding to the process group represented by the
given PID.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/killtree.hpp 2be2f8c3d58ee64410f87ee4a4b2bb54fe014748



Diff: https://reviews.apache.org/r/56367/diff/2/

Changes: https://reviews.apache.org/r/56367/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message