mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 57386: Introduced changes to the authz protos needed for RemoveNestedContainer.
Date Mon, 27 Mar 2017 09:36:42 GMT


> On March 9, 2017, 2:09 a.m., Vinod Kone wrote:
> > include/mesos/authorizer/acls.proto
> > Lines 448 (patched)
> > <https://reviews.apache.org/r/57386/diff/2/?file=1659012#file1659012line448>
> >
> >     move this to #440.

Sorry to have seen this too late, but in the authorization protobufs we try to keep the acl's
in order, given that there are too many entries and was getting hard to handle the introduction
of new acls and the ones we deleted already.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57386/#review168389
-----------------------------------------------------------


On March 10, 2017, 7:02 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57386/
> -----------------------------------------------------------
> 
> (Updated March 10, 2017, 7:02 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Jie Yu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-7120
>     https://issues.apache.org/jira/browse/MESOS-7120
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced changes to the authz protos needed for RemoveNestedContainer.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 8389917d12f9a9a3c9b4281f48e23ade14c20528 
>   include/mesos/authorizer/authorizer.proto fdc4817ce74c45d792fc47f064f7909a83b1657d

> 
> 
> Diff: https://reviews.apache.org/r/57386/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message