mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 57925: Added further tests for executor secret generation.
Date Sat, 25 Mar 2017 04:38:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57925/
-----------------------------------------------------------

(Updated March 25, 2017, 4:38 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6999
    https://issues.apache.org/jira/browse/MESOS-6999


Repository: mesos


Description
-------

This patch adds two further tests for executor secret
generation, `SlaveTest.RunTaskGroupReferenceTypeSecret`
and `SlaveTest.RunTaskGroupFailedSecretAfterShutdown`.


Diffs (updated)
-----

  src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a 


Diff: https://reviews.apache.org/r/57925/diff/4/

Changes: https://reviews.apache.org/r/57925/diff/3-4/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*SlaveTest.*Secret*"` was used to check the new tests.

NOTE: `SlaveTest.RunTaskGroupFailedSecretAfterShutdown` currently does not pass and needs
to be debugged.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message