mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 55065: Added support for s390x architecture
Date Wed, 22 Mar 2017 14:45:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55065/#review169708
-----------------------------------------------------------



Please make sure you fill out the "testing done" section with all the steps you used for validating
your changes?


src/linux/ldcache.cpp
Line 120 (original), 120 (patched)
<https://reviews.apache.org/r/55065/#comment242238>

    Can you elaborate why this change is safe for all systems?



src/slave/flags.cpp
Lines 152 (patched)
<https://reviews.apache.org/r/55065/#comment242237>

    We generally use `#ifdef` instead of `#if defined()`.
    
    Seems we could avoid a bit of duplication by only guarding the default value by the `ifdef`.


- Till Toenshoff


On March 22, 2017, 2:33 p.m., Ayanampudi Varsha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55065/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 2:33 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Bugs: MESOS-6742
>     https://issues.apache.org/jira/browse/MESOS-6742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for s390x architecture
> There are 2 issues addressed in this patch:
> 1. LdcacheTest.Parse test case fails on s390x machines.
> 2. From the value of flag docker_registry in slave/flags.cpp, amd64 images get downloaded
due to which test cases fail on s390x with "Exec format Error"
> 
> 
> Diffs
> -----
> 
>   src/linux/ldcache.cpp 6260496672cd0226a24ea1b34003a48af9678a63 
>   src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 
> 
> 
> Diff: https://reviews.apache.org/r/55065/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ayanampudi Varsha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message