mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 56218: Added a check test for default executor.
Date Mon, 20 Mar 2017 10:54:51 GMT


> On March 17, 2017, 11:07 a.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp
> > Lines 854 (patched)
> > <https://reviews.apache.org/r/56218/diff/5/?file=1666170#file1666170line854>
> >
> >     can you add a TODO to cleanup this file as follows:
> >     
> >     1) Move variables closer to their usage
> >     2) Do not use evolve/devolve but use v1 variables/helpers wherever possible
> >     
> >     please take a look at default_executor_tests.cpp for an example.

I've decided not to add a TODO, but cleaned up things now.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56218/#review169278
-----------------------------------------------------------


On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56218/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 4:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-7249
>     https://issues.apache.org/jira/browse/MESOS-7249
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 
> 
> 
> Diff: https://reviews.apache.org/r/56218/diff/5/
> 
> 
> Testing
> -------
> 
> Tested the complete chain starting at https://reviews.apache.org/r/56208/ 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message